Skip to content

Merge Reader Dashboard into Profile Portfolio tab#690

Merged
realproject7 merged 3 commits intomainfrom
task/684-merge-reader-dashboard
Mar 31, 2026
Merged

Merge Reader Dashboard into Profile Portfolio tab#690
realproject7 merged 3 commits intomainfrom
task/684-merge-reader-dashboard

Conversation

@realproject7
Copy link
Copy Markdown
Owner

@realproject7 realproject7 commented Mar 31, 2026

Summary

  • Portfolio tab now includes paginated Trading History with buy/sell badges, storyline titles, and USD values — visible for all profiles (public on-chain data)
  • Donations given (as reader) gated to own profile only
  • Holdings + donations received remain visible for all profiles (public)
  • /reader now redirects to /profile/[address]?tab=portfolio

Fixes #684

Test plan

  • Profile Portfolio tab shows full portfolio + trading history (own profile)
  • Other users' profiles show holdings + trades (read-only, public data)
  • Donation history only shows on own profile
  • Pagination works for trading history
  • USD values display correctly
  • /reader redirects to profile
  • npm run build passes ✅

🤖 Generated with Claude Code

@realproject7 @claude
[#684] Merge Reader Dashboard into Profile Portfolio tab
79f9ef8 
- Portfolio tab now includes paginated Trading History with buy/sell badges,
  storyline titles, USD values — visible for all profiles (public on-chain data)
- Donation history (given as reader) gated to own profile only
- /reader now redirects to /profile/[address]?tab=portfolio

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Mar 31, 2026 9:20pm

Request Review

project7-interns
project7-interns approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean reader dashboard consolidation: Trading History moved to PortfolioTab (public for all profiles), Donations Given properly gated behind isOwnProfile, /reader redirects to profile. Net -162 lines. All #684 acceptance criteria met.

project7-interns
project7-interns requested changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The redirect and public trading-history move are fine, but the merged Portfolio tab still does not carry over the full reader-dashboard behavior from #684. Two required pieces are still missing on the current head.

Findings

  • [medium] The Portfolio section still uses the older profile holdings view rather than the reader-dashboard portfolio summary, so it does not show the required 24h price-change/best-pick data from ReaderPortfolio.

    • File: src/app/profile/[address]/page.tsx:1311
    • Suggestion: Port the ReaderPortfolio behavior into PortfolioTab (or make ReaderPortfolio accept a profile address and render it here) so the Profile Portfolio tab includes the same 24h change and best-pick information as the old /reader dashboard.

  • [medium] Donation history is still the old non-paginated profile list capped at 20 rows, rather than the paginated reader-dashboard donation history required by #684.

    • File: src/app/profile/[address]/page.tsx:1242
    • Suggestion: Replace the current donationsGiven summary/list with the paginated donation-history flow from the old /reader dashboard so own-profile portfolio matches the original reader dashboard behavior.

Decision

Requesting changes because the current Portfolio tab still misses required reader-dashboard functionality from #684.

@realproject7 @claude
[#684] Fix review feedback: add 24h price change, best pick, paginate…
25bd010 
… donations

- Portfolio holdings now include 24h price change per token and best pick summary
- Uses get24hPriceChange + getTokenTVL for reserve decimals (matches ReaderPortfolio)
- Donations given now uses paginated useInfiniteQuery instead of capped query

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
project7-interns approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: both fixes confirmed. Holdings now include 24h price change per token + best pick summary (matching ReaderPortfolio). Donations given now paginated via useInfiniteQuery. LGTM.

project7-interns
project7-interns requested changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The latest head fixes the portfolio-summary and donation-pagination gaps from the previous review, but one Portfolio-tab regression still remains on the current revision.

Findings

  • [medium] PortfolioTab still returns the empty-state card before rendering PortfolioTradingHistory, so profiles with public trades but no current holdings or donations will incorrectly show "No holdings or donations yet" and hide the required trading-history section.
    • File: src/app/profile/[address]/page.tsx:1319
    • Suggestion: Include trading history in the empty-state decision, or render PortfolioTradingHistory outside that early return so profiles with trades but no current holdings/donations still satisfy #684.

Decision

Requesting changes because the Portfolio tab can still drop required public trading-history data for valid profiles.

@realproject7 @claude
[#684] Remove early return so trading history always renders
b521d5b 
Profiles with trades but no holdings/donations were hitting the empty
state early return, hiding the PortfolioTradingHistory section.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
project7-interns approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: early return removed so PortfolioTradingHistory renders for profiles with trades but no holdings/donations. Edge case fixed. LGTM.

project7-interns
project7-interns approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The latest head resolves the remaining Portfolio-tab blocker from the previous review. PortfolioTradingHistory is no longer hidden behind the old empty-state early return, and the merged reader-dashboard behavior now matches the #684 requirements.

Findings

  • None.

Decision

Approving because the current revision now carries over the required Portfolio summary, paginated donation history, public trading history, and /reader redirect behavior into the profile page.

@realproject7 realproject7 merged commit 9a37a53 into main Mar 31, 2026
5 checks passed
@realproject7 realproject7 deleted the task/684-merge-reader-dashboard branch March 31, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@project7-interns project7-interns project7-interns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[#682] Sub-2: Merge Reader Dashboard into Profile Portfolio tab

2 participants

@realproject7 @project7-interns